fix(core/card): adjust selected background color #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a6812b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthiashader
force-pushed
the
fix/981-action-card
branch
from
92a7924
to
90c6889
Compare
# Conflicts: # packages/core/src/tests/action-card/action-card.e2e.ts-snapshots/action-card-basic-should-have-selected-state-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/action-card/action-card.e2e.ts-snapshots/action-card-basic-should-have-selected-state-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/action-card/action-card.e2e.ts-snapshots/action-card-basic-should-not-have-visual-regressions-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/action-card/action-card.e2e.ts-snapshots/action-card-basic-should-not-have-visual-regressions-1-chromium---theme-classic-light-linux.png
nuke-ellington
requested changes
Mar 25, 2024
...shots/action-card-basic-should-have-selected-state-1-chromium---theme-classic-dark-linux.png
Outdated
Show resolved
Hide resolved
danielleroux
requested changes
Mar 26, 2024
danielleroux
approved these changes
Mar 27, 2024
nuke-ellington
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
GitHub Issue Number: N/A
Will resolve [IX-981] and [IX-981]
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
yarn docs)yarn test)yarn visual-regression)yarn lint)yarn build, changes pushed)👨💻 Help & support