Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/slider): fix tick color #1175

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix(core/slider): fix tick color #1175

merged 2 commits into from
Mar 22, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Mar 20, 2024

๐Ÿ’ก What is the current behavior?

  • currently the tick-color of the ix-slider is color-7

GitHub Issue Number: #N/A

๐Ÿ†• What is the new behavior?

  • tick-color of the ix-slider is now color-8

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (yarn docs)
  • ๐Ÿงช Unit tests were added/updated and pass (yarn test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (yarn visual-regression)
  • ๐Ÿง Static code analysis passes (yarn lint)
  • ๐Ÿ—๏ธ Successful compilation (yarn build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Mar 20, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 4bc6339

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nuke-ellington
nuke-ellington previously approved these changes Mar 20, 2024
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR description looks empty for me, please fill out.
  • Changeset missing for version bump

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 21, 2024
@danielleroux danielleroux merged commit f31adf0 into main Mar 22, 2024
9 checks passed
@danielleroux danielleroux deleted the fix/541-slider branch March 22, 2024 08:16
This was referenced Mar 22, 2024
matthiashader added a commit that referenced this pull request Mar 25, 2024
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants