Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blind): provided ellipsis for blind header #1186

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

ridvandmrc
Copy link
Contributor

๐Ÿ’ก What is the current behavior?

If a long label is used, Ellipsis is not looking .

GitHub Issue Number: #1165

๐Ÿ†• What is the new behavior?

  • I removed some css property because it is blocking ellipsis

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (yarn docs)
  • ๐Ÿงช Unit tests were added/updated and pass (yarn test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (yarn visual-regression)
  • ๐Ÿง Static code analysis passes (yarn lint)
  • ๐Ÿ—๏ธ Successful compilation (yarn build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Mar 22, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: caba100

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux
Copy link
Collaborator

@ridvandmrc Looks like there are some errors in our visual testing environment.

You find a html test report on your Pull Request-Workflow e.g https://github.com/siemens/ix/actions/runs/8392413573, scroll down to the bottom and check the file core-html-report--attempt-1 to view the report.

To get some information about visual testing checkout our short guide: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing

@ridvandmrc
Copy link
Contributor Author

Hi @danielleroux ,
In order to show the text ellipsis, I had to arrange the width of the content but it is not too much, so I am getting the error. But the changes will not affect anything because the result is:

image

@danielleroux
Copy link
Collaborator

danielleroux commented Mar 26, 2024

Hi @danielleroux , In order to show the text ellipsis, I had to arrange the width of the content but it is not too much, so I am getting the error. But the changes will not affect anything because the result is:

image

The sublabel has to be aligned centered within the blind.
This is also not given by the current implementation:

        <ix-blind
          label="Test long long long long long long long 123 456 789"
          sublabel="Sub long long long long long 123 456 789"
          style={{ width: '40rem' }}
        ></ix-blind>

image

The label text max with should be half of the blind (text content), following by the sublabel. All labels have to be showing ellipses as text overflow style. If you have access you can checkout the figma specs: https://www.figma.com/file/r2nqdNNXXZtPmWuVjIlM1Q/iX-Components---Brand-Dark?node-id=9598%3A189577

Spec:
image

@ridvandmrc
Copy link
Contributor Author

Hi @danielleroux ,
I understand what you said, I updated the code and also It is working as expected.

image

Thanks

@danielleroux
Copy link
Collaborator

Hi @danielleroux , I understand what you said, I updated the code and also It is working as expected.

image

Thanks

Thank you.

As mentioned in the PR template, please add some testcases (visual regression tests) to verify the changes.

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing visual-regression test cases

@danielleroux
Copy link
Collaborator

@ridvandmrc Please checkout the CONTRIBUTING.md. There is a chapter regarding visual tests. You have to run it inside a container.

danielleroux
danielleroux previously approved these changes Apr 2, 2024
matthiashader
matthiashader previously approved these changes Apr 2, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated margin. Please also delete the "blind-sublabel-" snapshots since they are obsolete.

packages/core/src/components/blind/blind.scss Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit b7a56fe into siemens:main Apr 3, 2024
11 checks passed
@danielleroux danielleroux deleted the fix/blind branch April 3, 2024 10:12
This was referenced Apr 3, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants