Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(echarts): align charting colors #1190

Merged
merged 73 commits into from
Apr 16, 2024
Merged

fix(echarts): align charting colors #1190

merged 73 commits into from
Apr 16, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Mar 27, 2024

๐Ÿ’ก What is the current behavior?

Overview:

  • echarts are not themed correctly
  • visual regression tests are missing
  • examples are missing
  • stackblitz and preview are not working
  • docu is wrong

Jira: IX-606, IX-854

๐Ÿ†• What is the new behavior?

Overview:

  • echarts themes have been corrected
  • visual regression tests have been added
  • examples have been added
  • stackblitz and preview have been fixed
  • docu has been adapted

Details:

  • Modified the themes in ix-echarts.
  • Incorporated visual regression tests into ix-echarts and updated pipelines.
  • Altered the package logic of ix-echarts to use the window object echarts and removed the method call upon import.
  • Introduced echarts examples for all frameworks.
  • Adjusted code runtimes to accommodate echarts.
  • Tweaked the code runtime logic to utilize the current theme, which is essential for echarts.
  • Adapted the code runtime logic for HTML to include the necessary imports for echarts.
  • Updated the documentation to accurately explain the installation process and showcase examples for all frameworks.
  • Enhanced the open preview function to incorporate the theme and noMargin option, which are required for echarts.

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Mar 27, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 84100d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix-echarts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jul-lam jul-lam self-assigned this Mar 27, 2024
@danielleroux danielleroux removed the Deploy Preview Deploy a preview instance of the documentation label Apr 5, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
@danielleroux danielleroux changed the title fix(echarts): themes fix(echarts): align charting colors Apr 15, 2024
@danielleroux danielleroux merged commit 7c13c7f into main Apr 16, 2024
10 checks passed
@danielleroux danielleroux deleted the fix/echarts-themes branch April 16, 2024 05:56
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants