Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown): fix runtime & detach issues #1192

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Mar 28, 2024

๐Ÿ’ก What is the current behavior?

  • When detaching and attaching the ix-dropdown inside the DOM, the dropdown stop working, it is not possible to actually open the dropdown again
  • When in the runtime a element is added to the DOM, with the ID 'undefined' the trigger wil be set to this element and not longer be available on the button / select and so on.

GitHub Issue Number: #1136

๐Ÿ†• What is the new behavior?

  • When the dropdown is attached again to the DOM the listeners are initialised again
  • When a new element with ID 'undefined' is added, a condition will prevent the element from actually setting it as trigger element

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Mar 28, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 9f32b7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader linked an issue Mar 28, 2024 that may be closed by this pull request
2 tasks
@matthiashader matthiashader marked this pull request as draft March 28, 2024 13:21
@matthiashader matthiashader marked this pull request as ready for review April 8, 2024 06:29
.changeset/tidy-berries-tan.md Outdated Show resolved Hide resolved
packages/core/src/tests/dropdown/dropdown.e2e.ts Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit 1876e96 into main Apr 11, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/991-dropdown branch April 11, 2024 05:51
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown doesn't work with virtual scroll, split button issue
2 participants