-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/select): reset input text on blur #1195
Conversation
user DOM manipulation to update it
๐ฆ Changeset detectedLatest commit: 5739df9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
๐โโ๏ธ Please don't ignore the checklist of the pull request after you already checked the points. There is no testcase added. |
Done ๐ |
Upon review, I identified a minor error. When the select component is utilized with the Code:
|
Hi @danielleroux, @jul-lam |
Hi @ridvandmrc In the given example, the 'add' field ( |
Hi @jul-lam , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it looks good! Nonetheless, could you please add one more test for the editable case.
Hi @jul-lam @danielleroux , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests.
user DOM manipulation to update it
๐ก What is the current behavior?
Label is not visible if text is removed from input.
GitHub Issue Number: Closes #1191
๐ What is the new behavior?
๐ Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)๐จโ๐ป Help & support