Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/select): arrow key navigation #1196

Merged
merged 14 commits into from
Apr 23, 2024
Merged

fix(core/select): arrow key navigation #1196

merged 14 commits into from
Apr 23, 2024

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Apr 5, 2024 •
edited

💡 What is the current behavior?

GitHub Issue Number: IX-933

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Apr 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited

🦋 Changeset detected

Latest commit: 7a74909

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nuke-ellington nuke-ellington marked this pull request as draft April 5, 2024 14:53
@nuke-ellington nuke-ellington changed the title Fix/933 select arrow nav fix(core/select): arrow key navigation Apr 5, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
@danielleroux danielleroux marked this pull request as ready for review April 19, 2024 08:52
@danielleroux danielleroux self-assigned this Apr 19, 2024
danielleroux
danielleroux requested changes Apr 19, 2024
View reviewed changes
packages/core/src/components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dropdown/dropdown.tsx Show resolved Hide resolved
packages/core/src/components/select/select.scss Outdated Show resolved Hide resolved
packages/core/src/components/select/select.tsx Outdated Show resolved Hide resolved
packages/core/src/components/select/select.tsx Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit 04b03d4 into main Apr 23, 2024
13 checks passed
@danielleroux danielleroux deleted the fix/933-select-arrow-nav branch April 23, 2024 07:14
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees

@danielleroux danielleroux

Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuke-ellington @danielleroux