Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/card-list): make show all button optional #1197

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

nuke-ellington
Copy link
Collaborator

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: IX-1019

๐Ÿ†• What is the new behavior?

  • Show all button can be toggled via property

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

@nuke-ellington nuke-ellington added the pull request affects minor version The pull request affects only minor version label Apr 8, 2024
@nuke-ellington nuke-ellington added this to the 2.2.0 milestone Apr 8, 2024
Copy link

changeset-bot bot commented Apr 8, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 6b74a6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-react Minor
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux merged commit 3cd3da9 into main Apr 9, 2024
12 checks passed
@danielleroux danielleroux deleted the feat/1019-car-list-show-all-optional branch April 9, 2024 05:09
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants