Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/workflow-steps): fix initial layout shift #1198

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Apr 8, 2024

๐Ÿ’ก What is the current behavior?

  • When loading the page while using the ix-workflow (in vertical orientation) the single steps initially loading horizontally

GitHub Issue Number: Closes #1053

๐Ÿ†• What is the new behavior?

  • The orientation of the single steps where already updated in the componentWillLoad()
  • The single ix-workflow steps load initially with the correct orientation

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Apr 8, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: ddef24d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft April 8, 2024 11:49
@matthiashader matthiashader marked this pull request as ready for review April 11, 2024 07:02
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a component test?

.changeset/bright-pugs-know.md Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit 87f0e37 into main Apr 16, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/871-workflow branch April 16, 2024 08:24
@matthiashader
Copy link
Collaborator Author

Could you please add a component test?

As this fix only affects the componentWillLoad() Lifecycle it is hard to test, because after the mount() (in the component test) componentWillLoad was already called. Also the bug only affected a short flicker at the beginning.

@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-workflow component having a glitch while loading
2 participants