Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/menu-item): show tooltip on hover #1200

Merged
merged 16 commits into from
Apr 16, 2024

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Apr 8, 2024

๐Ÿ’ก What is the current behavior?

Jira: IX-896

๐Ÿ†• What is the new behavior?

Workflow changes

Run some main workflow not on forks

ix-menu-item

Show tooltip if menu is collapsed

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Apr 8, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: b578212

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-react Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-angular Minor
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux marked this pull request as draft April 9, 2024 05:16
@danielleroux danielleroux marked this pull request as ready for review April 9, 2024 05:38
@danielleroux danielleroux added the Deploy Preview Deploy a preview instance of the documentation label Apr 11, 2024
@danielleroux danielleroux removed the Deploy Preview Deploy a preview instance of the documentation label Apr 12, 2024
@siemens siemens deleted a comment from github-actions bot Apr 12, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
nuke-ellington
nuke-ellington previously approved these changes Apr 12, 2024
nuke-ellington
nuke-ellington previously approved these changes Apr 15, 2024
packages/core/src/components/tooltip/tooltip.tsx Outdated Show resolved Hide resolved
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux merged commit 179ca17 into main Apr 16, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/show-menu-item-tooltip branch April 16, 2024 07:53
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants