Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/toast|react/toast|vue/toast): predefine custom elements before usage #1201

Merged
merged 14 commits into from
Apr 15, 2024

Conversation

danielleroux
Copy link
Collaborator

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: Closes #1066 Closes #1006

๐Ÿ†• What is the new behavior?

  • Predefine toast-container and toast custom element before usage

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented Apr 8, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: bf61fce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix-react Patch
@siemens/ix Patch
@siemens/ix-vue Patch
@siemens/ix-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux marked this pull request as draft April 9, 2024 05:17
@danielleroux danielleroux marked this pull request as ready for review April 12, 2024 06:03
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
@danielleroux danielleroux changed the title fix(core/toast|react/toast|vue/toast): prefine custom elements before usage fix(core/toast|react/toast|vue/toast): predefine custom elements before usage Apr 12, 2024
@danielleroux danielleroux merged commit 34b50ef into main Apr 15, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/register-webcomponent-before-usage branch April 15, 2024 09:00
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast icons are not showing up after build stage iX[2.0.4] in React production build showToast error.
2 participants