Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select-item): check by undefined not by value #1214

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Apr 11, 2024

๐Ÿ’ก What is the current behavior?

0 is currently not a valid value option for the ix-select-item.

GitHub Issue Number: xxx

๐Ÿ†• What is the new behavior?

0 is now a valid value option for the ix-select-item.

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

The test is skipped, since html only uses string values, which the value prop also will use in 3.0.

Copy link

changeset-bot bot commented Apr 11, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: ae95b85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jul-lam jul-lam self-assigned this Apr 11, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 12, 2024
@danielleroux danielleroux changed the title fix(select-item): make 0 a valid value option fix(core/select-item): check by undefined not by value Apr 12, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test case?

@jul-lam
Copy link
Collaborator Author

jul-lam commented Apr 15, 2024

@nuke-ellington - I havenโ€™t set up a test because HTML exclusively uses string values for properties. We could however set up a test using React, but I was not sure if thatโ€™s needed, since our value property will take exclusively string in our next major release.

@danielleroux danielleroux merged commit 22a83d9 into main Apr 15, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/value-must-be-defined branch April 15, 2024 09:07
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants