Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(content-header): add ux styleguide #1216

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Conversation

katjaKoppensteiner
Copy link
Collaborator

@katjaKoppensteiner katjaKoppensteiner commented Apr 12, 2024

๐Ÿ’ก What is the current behavior?

No UX documentation for Content Header

IX-502

๐Ÿ†• What is the new behavior?

UX documentation for Content header

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

content header styleguide
@katjaKoppensteiner katjaKoppensteiner self-assigned this Apr 12, 2024
Copy link

changeset-bot bot commented Apr 12, 2024

โš ๏ธ No Changeset found

Latest commit: e756559

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielleroux danielleroux changed the title Create _content-header_styleguide.md docs(content-header): add ux styleguide Apr 12, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 19, 2024
@danielleroux danielleroux merged commit 5707d7f into main Apr 23, 2024
10 checks passed
@danielleroux danielleroux deleted the docs/content-header branch April 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants