Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/tooltip): prevent focusin event call showTooltip #1221

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

danielleroux
Copy link
Collaborator

๐Ÿ’ก What is the current behavior?

IX-896

๐Ÿ†• What is the new behavior?

Prevent tooltip focusin event to call showTooltip, if a setTimeout call is already running.

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

@danielleroux danielleroux added this to the 2.2.0 milestone Apr 16, 2024
Copy link

changeset-bot bot commented Apr 16, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: cbc15bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux merged commit 555a5a3 into main Apr 17, 2024
13 checks passed
@danielleroux danielleroux deleted the fix/tooltip-focusin branch April 17, 2024 08:15
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants