Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown): add null check for trigger element #1241

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Apr 24, 2024

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: Closes #1240

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Apr 24, 2024
Copy link

changeset-bot bot commented Apr 24, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: a4c4877

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux removed the pull request affects patch version The pull request affects only patch version label Apr 24, 2024
@danielleroux danielleroux merged commit b38d2d3 into main Apr 24, 2024
13 checks passed
@danielleroux danielleroux deleted the fix/1240-dropdown-key-listener branch April 24, 2024 10:31
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After v2.2.0, menu category throws error on hover
2 participants