Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): button examples #127

Merged
merged 5 commits into from
Nov 18, 2022
Merged

fix(documentation): button examples #127

merged 5 commits into from
Nov 18, 2022

Conversation

goncalosard
Copy link
Contributor

Summary

Button examples added to the documentation.

Build failed because of file component-doc.json because i'm developing on windows device.
Works perfectly on my device.
Please run this branch on your device and add the file again, it should fix the problem.

How did you test this change?

Tested locally

@goncalosard goncalosard added the Documentation Improvements or additions to documentation label Nov 9, 2022
@goncalosard goncalosard linked an issue Nov 9, 2022 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button page should be structured similar to the zeplin specs page with separate section per class (e.g. Primary buttons, Secondary..).

@danielleroux danielleroux added this to the 1.1.1 milestone Nov 11, 2022
@danielleroux
Copy link
Collaborator

@silviowolf can you give us feedback regarding the button namings in figma? This PR is depending on it.

@danielleroux
Copy link
Collaborator

danielleroux commented Nov 18, 2022

I renamed the button page togther with @silviowolf

@nuke-ellington Can you please do a re-review 😇

@danielleroux danielleroux merged commit 0f79e92 into main Nov 18, 2022
@danielleroux danielleroux deleted the fix/button-examples branch November 18, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Button examples incomplete
3 participants