Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): bump stencil to current version #139

Conversation

AndreasBerliner
Copy link
Contributor

@AndreasBerliner AndreasBerliner commented Nov 15, 2022

Summary

Bumped stencil.js to the current version (2.19.2).
This should also fix the following issue and provide compatibility for web components in vue.js
Link to issue on stackoverflow.com

How did you test this change?

build stencil locally

@danielleroux danielleroux self-assigned this Nov 15, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please update also yarn.lock regarding changes of dependencies
  • also updating stencil sass dependency to 2.0.0

@danielleroux danielleroux added this to the 1.1.0 milestone Nov 15, 2022
@danielleroux danielleroux self-requested a review November 16, 2022 06:34
@danielleroux danielleroux mentioned this pull request Nov 16, 2022
1 task
danielleroux
danielleroux previously approved these changes Nov 16, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux self-requested a review November 16, 2022 08:51
@danielleroux danielleroux dismissed their stale review November 16, 2022 08:52

Dependency prefix unclear

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Nov 18, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 0e0e669 into siemens:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants