Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/map-navigation): use ix-application-header for header part #169

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

danielleroux
Copy link
Collaborator

Summary

Reuse ix-application-header inside map-navigation

How did you test this change?

Update visual regression snapshots

@danielleroux danielleroux added component: core pull request affects patch version The pull request affects only patch version labels Nov 23, 2022
@danielleroux danielleroux added this to the 1.1.1 milestone Nov 23, 2022
@danielleroux danielleroux linked an issue Nov 23, 2022 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App name seems too close to icon slot. Siemens logo f.e. will not look good like that.

@danielleroux
Copy link
Collaborator Author

App name seems too close to icon slot. Siemens logo f.e. will not look good like that.

@nuke-ellington
image

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not meet design spec fully but should not be problematic.

@danielleroux danielleroux merged commit de31afa into main Nov 23, 2022
@danielleroux danielleroux deleted the 168-map-navigation-has-not-logo-slot branch November 23, 2022 13:41
@danielleroux danielleroux self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

map-navigation has not logo slot
2 participants