Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): radiobutton corrected design spec #186

Merged
merged 8 commits into from
Nov 30, 2022

Conversation

goncalosard
Copy link
Contributor

Summary

Fix #175

Changed the size to the corrected size and also aligned the center circle that was not aligned.

How did you test this change?

Tested locally.

packages/core/scss/components/_radiobuttons.scss Outdated Show resolved Hide resolved
@danielleroux danielleroux added type: bug Something isn't working pull request affects patch version The pull request affects only patch version labels Nov 28, 2022
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit f79e099 into main Nov 30, 2022
@danielleroux danielleroux deleted the fix/radio-button-alignment branch November 30, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

radiobutton size is not aligend with design sepc
3 participants