Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular/modal-service): pass config object to modal function #200

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Nov 30, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Angular modal service did not pass all config objects to core modal function

Discussed in: https://github.com/siemens/ix/discussions/178

What is the new behavior?

  • Pass config object to function by spread operator

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • add angular unit test to test modal service
  • add react unit test to test modal function

Other information

@danielleroux danielleroux added type: bug Something isn't working component: angular pull request affects patch version The pull request affects only patch version labels Nov 30, 2022
@danielleroux danielleroux added this to the 1.1.2 milestone Nov 30, 2022
@danielleroux danielleroux merged commit 8b5f163 into main Dec 2, 2022
@danielleroux danielleroux deleted the fix/angular-modal-service branch December 2, 2022 06:39
@danielleroux danielleroux modified the milestones: 1.1.2, 1.2.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants