Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/icon-button): adjust styling of smaller buttons #218

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

#167 will not be directly fixed. This fix will come with an adjustment of the icon clear-button. (@silviowolf make clear button bigger)

What is the new behavior?

  • Refactor class structure of ix-icon-button
  • Fix style issue in small icon button

Does this introduce a breaking change?

  • Yes
  • No

Testing

Add visual regression test

@danielleroux danielleroux added type: enhancement New feature or request component: core pull request affects patch version The pull request affects only patch version labels Dec 6, 2022
@danielleroux danielleroux added this to the 1.1.2 milestone Dec 6, 2022
@danielleroux danielleroux merged commit e29271b into main Dec 6, 2022
@danielleroux danielleroux deleted the fix/icon-button branch December 6, 2022 10:32
@danielleroux danielleroux modified the milestones: 1.1.2, 1.2.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants