Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/group): show context-menu based on dropdown #222

Merged
merged 7 commits into from
Dec 7, 2022

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #152

What is the new behavior?

  • Use dropdown in slot to display context-menu

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added type: bug Something isn't working component: core pull request affects patch version The pull request affects only patch version labels Dec 6, 2022
@danielleroux danielleroux added this to the 1.2.0 milestone Dec 6, 2022
@danielleroux danielleroux linked an issue Dec 6, 2022 that may be closed by this pull request
@danielleroux danielleroux changed the title Fix/group dropdown fix(core/group): show context-menu based on dropdown Dec 6, 2022
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we improve the dropdown placement in relation to the button/header?
I cannot find a refernce in the styleguide but it looks a little off to me :)

@danielleroux
Copy link
Collaborator Author

danielleroux commented Dec 7, 2022

@nuke-ellington
It is off because of the popperjs implementation. Its fixed in #137 (#153 )

@danielleroux danielleroux merged commit 2bffcb7 into main Dec 7, 2022
@danielleroux danielleroux deleted the fix/group-dropdown branch December 7, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

group context menu not showing
2 participants