-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/dropdown-button): add dropdown-button #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- documentation is missing
- angular (angular-test-app/preview-examples) examples are missing
- react (react-test-app/preview-examples) examples are missing
- html (html-test-app/preview-examples) examples are missing
packages/core/src/components/dropdown-button/dropdown-button.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DropdownButton should also provide a possiblity to open a dropdown e.g.
<ix-dropdown-button>
<ix-dropdown-item></ix-dropdown-item>
<ix-dropdown-item></ix-dropdown-item>
....
</ix-dropdown-button>
See ix-select
@danielleroux |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Implemented new component dropdown-button as requested in #173
A new prop in icon-button was also implemented to let the small triangle to be toggle when its used on a dropdown-button.
Build is not passing because of the problem that i'm Windows, so the file component-doc.json needs to be re-commited by someone with mac.
Visual-regression tests for this new component are created, but it is needed to check if any onther tests are failing and the new
snapshots need to be commited.
Code used for testing
Testing
Tested locally