Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): pill alignment #255

Merged
merged 6 commits into from
Jan 13, 2023
Merged

fix(core): pill alignment #255

merged 6 commits into from
Jan 13, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #243

image

What is the new behavior?

Pills with icon and without icon now have the same height.
image

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested Locally

Other information

@goncalosard goncalosard added type: bug Something isn't working component: core labels Dec 16, 2022
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Dec 16, 2022
@danielleroux danielleroux added this to the next-release milestone Dec 16, 2022
@danielleroux danielleroux linked an issue Dec 16, 2022 that may be closed by this pull request
Pill with icon alignes different than without icon #243
Closed
@danielleroux danielleroux mentioned this pull request Dec 19, 2022
Merged
14 tasks
@goncalosard
Copy link
Contributor Author

@danielleroux Fixed, please review.

@danielleroux
Copy link
Collaborator

@goncalosard Why are there so many file changes?

@danielleroux
Copy link
Collaborator

@goncalosard Why are there so many file changes?

I merged the main again, additional file changes should now be gone

@danielleroux danielleroux removed the type: bug Something isn't working label Jan 13, 2023
nuke-ellington
nuke-ellington approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

danielleroux
danielleroux approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 1e0fa2f into main Jan 13, 2023
@danielleroux danielleroux deleted the fix/pill-alignment branch January 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
Siemens iX
Status: Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Pill with icon alignes different than without icon
3 participants
@goncalosard @danielleroux @nuke-ellington