Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aggrid): remove clip from ag-radiobutton #260

Merged

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Remove clip and clip-path from ag related inputs, because click listener of aggrid subscribed for direct <input/> clicks.

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added type: bug Something isn't working pull request affects patch version The pull request affects only patch version component: aggrid labels Dec 19, 2022
@danielleroux danielleroux added this to the next-release milestone Dec 19, 2022
@danielleroux danielleroux linked an issue Dec 19, 2022 that may be closed by this pull request
@danielleroux danielleroux merged commit 7536529 into main Dec 19, 2022
@danielleroux danielleroux deleted the 253-radiobutton-in-aggrid-filter-is-not-clickable branch December 19, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Radiobutton in AGGrid Filter is not clickable
2 participants