Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(echarts): update theme colors #281

Merged
merged 5 commits into from
Jan 13, 2023
Merged

fix(echarts): update theme colors #281

merged 5 commits into from
Jan 13, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Enhance registerTheme method with possibility to pass echarts instance
  • Expose theme objects
  • Update colors for classic theme

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added component: echart pull request affects minor version The pull request affects only minor version labels Jan 10, 2023
@danielleroux danielleroux added this to the 1.3.0 milestone Jan 10, 2023
@danielleroux danielleroux linked an issue Jan 10, 2023 that may be closed by this pull request
font color of echart theme not readable in dark themes #20
Closed
@danielleroux danielleroux changed the title 20 font color of echart theme not readable in dark themes fix(echarts): update theme colors Jan 10, 2023
nuke-ellington
nuke-ellington approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 8a0cbff into main Jan 13, 2023
@danielleroux danielleroux deleted the 20-font-color-of-echart-theme-not-readable-in-dark-themes branch January 13, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
Siemens iX
Status: Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

font color of echart theme not readable in dark themes
2 participants
@danielleroux @nuke-ellington