Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/category-filter, core/expanding-search): adjust clear button #303

Merged
merged 5 commits into from
Jan 23, 2023
Merged

fix(core/category-filter, core/expanding-search): adjust clear button #303

merged 5 commits into from
Jan 23, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jan 16, 2023 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Replace clear button implementation with ix-icon-button implementation
  • Add visual regression test

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Jan 16, 2023
@danielleroux danielleroux added this to the 1.3.0 milestone Jan 16, 2023
@danielleroux danielleroux linked an issue Jan 16, 2023 that may be closed by this pull request
Category filter clear button styling #167
Closed
nuke-ellington
nuke-ellington reviewed Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter should not be multiline if there is enough horizontal space (see snapshot).

@danielleroux danielleroux merged commit 87574a6 into main Jan 23, 2023
@danielleroux danielleroux deleted the 167-category-filter-clear-button-styling branch January 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Category filter clear button styling
2 participants
@danielleroux @nuke-ellington