Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/tooltip): add ix-tooltip #309

Merged
merged 13 commits into from
Feb 7, 2023
Merged

feat(core/tooltip): add ix-tooltip #309

merged 13 commits into from
Feb 7, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Implement tooltip

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • Visual regression tests added

ToDo

  • use css custom properties
  • fix visual regression test after final style improvements.

@danielleroux danielleroux linked an issue Jan 18, 2023 that may be closed by this pull request
create a tooltip component #80
Closed
@danielleroux danielleroux changed the title 80 create a tooltip component feat(core/tooltip): implement ix-tooltip component Jan 18, 2023
@danielleroux danielleroux added this to the 1.3.0 milestone Jan 18, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jan 18, 2023
@danielleroux danielleroux modified the milestones: 1.3.0, next-release Jan 26, 2023
@danielleroux danielleroux changed the title feat(core/tooltip): implement ix-tooltip component feat(core/tooltip): add ix-tooltip Feb 1, 2023
@danielleroux danielleroux marked this pull request as ready for review February 1, 2023 15:45
nuke-ellington
nuke-ellington approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit ca3e8a2 into main Feb 7, 2023
@danielleroux danielleroux deleted the 80-create-a-tooltip-component branch February 7, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

create a tooltip component
2 participants
@danielleroux @nuke-ellington