Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/datetime picker #31

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Fix/datetime picker #31

merged 6 commits into from
Oct 12, 2022

Conversation

goncalosard
Copy link
Contributor

Summary

Fixing the problem with the date picker and time picker not aligning inside the datetimepicker component. Also improved the separator bar that now extends with the box width sizing on the datetimepicker component.

How did you test this change?

Tested locally.

@danielleroux danielleroux linked an issue Oct 7, 2022 that may be closed by this pull request
@danielleroux danielleroux added this to the 1.0.1 milestone Oct 7, 2022
@danielleroux danielleroux linked an issue Oct 7, 2022 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test snapshots and it looks like the box shadow is still wrong in classic dark.

@nuke-ellington nuke-ellington merged commit 1a4828d into main Oct 12, 2022
@danielleroux danielleroux deleted the fix/datetime-picker branch October 12, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetimepicker layout between date and time picker is not aligned wrong shadow in datepicker and timepicker
3 participants