Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blind): add ux description #323

Merged
merged 8 commits into from
Feb 14, 2023
Merged

Conversation

linstedt
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • added UX description and illustrations for control Blind

Other information

Review required:
[ ] accuracy and comprehensiveness of description
[ ] new picture location for illustrations - location and references acceptable?
[ ] should we report sizes/ spacing ? If so, how (unit)?
[ ] Code preview section untouched except headlines, a more condensed preview would be helpful for more complex controls

General question: Which ones of the PR requirements above apply to documentation extensions?

@linstedt linstedt added the Documentation Improvements or additions to documentation label Jan 25, 2023
@linstedt linstedt self-assigned this Jan 25, 2023
@danielleroux danielleroux changed the title Docs/update description blind docs(blind): add ux description Jan 26, 2023
@danielleroux danielleroux modified the milestones: 1.3.0, 1.4.0 Jan 26, 2023
@danielleroux danielleroux added the triage We discuss this topic in our internal weekly label Feb 1, 2023
@danielleroux danielleroux modified the milestones: 1.4.0, next-release Feb 6, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 51fa6bd into main Feb 14, 2023
@danielleroux danielleroux deleted the docs/UpdateDescriptionBlind branch February 14, 2023 13:29
@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.0 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation triage We discuss this topic in our internal weekly
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants