Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/dropdown): submenu and quickactions #325

Merged
merged 26 commits into from
Feb 17, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #144

What is the new behavior?

Now is possible to have a quick-actions and submenu on the dropdown component.

New prop (triggerEvent) implemented on the dropdown component, so now the user can choose to open with hover, but its not working 100%, needs to be cheked.

New components implemented: ix-divider & ix-dropdown-quick-actions

Example for quick-actions & submenu are done. (only missing Angular on the documentations, examples are done in Angular but the angular package is broken for me and it doesnt let me build the Angular package so i cannot run the examples on the docs).

Visual regression test is created for the quick-actions component.
Visual regression tetsts need to be checked and snapshots submitted.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added Documentation Improvements or additions to documentation component: core type: feature labels Jan 25, 2023
@danielleroux danielleroux added pull request affects minor version The pull request affects only minor version and removed type: feature labels Jan 26, 2023
@danielleroux danielleroux linked an issue Jan 26, 2023 that may be closed by this pull request
2 tasks
@danielleroux danielleroux removed Documentation Improvements or additions to documentation component: core labels Jan 26, 2023
@danielleroux danielleroux added this to the next-release milestone Jan 26, 2023
@nuke-ellington nuke-ellington requested review from nuke-ellington and removed request for danielleroux January 31, 2023 09:14
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See three comments please :)

packages/core/src/components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
@danielleroux danielleroux changed the title Feature/dropdown submenu & quick-actions feat(core/dropdown): implement submenu and quickactions Jan 31, 2023
@danielleroux danielleroux changed the title feat(core/dropdown): implement submenu and quickactions feat(core/dropdown): submenu and quickactions Jan 31, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation

  • Divider documentation is missing

Tests

  • Visual regression test for divider is missing
  • quick-actions visual regression test is no divider visible

@goncalosard
Copy link
Contributor Author

@danielleroux Fixed everything asked above. Please review.

About "quick-actions visual regression test is no divider visible", the snapshot is outdated, because the variable for the color on Figma had no match yet in the code so it was pointing to nothing. But it has now so it is just needed to run the tests again to get the new snapshots.

@danielleroux
Copy link
Collaborator

@goncalosard have you merged main?

@danielleroux
Copy link
Collaborator

danielleroux commented Feb 8, 2023

hover effect cause some weird behavior.

@nuke-ellington should that behavior be intended?

        <ix-button id="test">test</ix-button>
        <ix-dropdown trigger={'test'} triggerEvent={'mouseover'}>
          <ix-dropdown-item>Test</ix-dropdown-item>
          <ix-dropdown-item>Test</ix-dropdown-item>
          <ix-dropdown-item>Test</ix-dropdown-item>
        </ix-dropdown>

Result:

Screen.Recording.2023-02-08.at.16.56.41.mov

@danielleroux danielleroux self-requested a review February 16, 2023 06:42
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuke-ellington nuke-ellington merged commit 6694625 into main Feb 17, 2023
@danielleroux danielleroux deleted the feature/dropdown-sub-items branch February 22, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdown submenu and quick actions
3 participants