-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/dropdown): submenu and quickactions #325
Conversation
packages/core/src/components/dropdown-quick-actions/test/basic/index.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See three comments please :)
…ns/ix into feature/dropdown-sub-items
…pdown-sub-items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation
- Divider documentation is missing
Tests
- Visual regression test for divider is missing
- quick-actions visual regression test is no divider visible
packages/core/src/components/dropdown-quick-actions/dropdown-quick-actions.tsx
Show resolved
Hide resolved
packages/angular-test-app/src/preview-examples/dropdown-quick-actions.ts
Outdated
Show resolved
Hide resolved
@danielleroux Fixed everything asked above. Please review. About "quick-actions visual regression test is no divider visible", the snapshot is outdated, because the variable for the color on Figma had no match yet in the code so it was pointing to nothing. But it has now so it is just needed to run the tests again to get the new snapshots. |
@goncalosard have you merged main? |
hover effect cause some weird behavior. @nuke-ellington should that behavior be intended? <ix-button id="test">test</ix-button>
<ix-dropdown trigger={'test'} triggerEvent={'mouseover'}>
<ix-dropdown-item>Test</ix-dropdown-item>
<ix-dropdown-item>Test</ix-dropdown-item>
<ix-dropdown-item>Test</ix-dropdown-item>
</ix-dropdown> Result: Screen.Recording.2023-02-08.at.16.56.41.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #144
What is the new behavior?
Now is possible to have a quick-actions and submenu on the dropdown component.
New prop (triggerEvent) implemented on the dropdown component, so now the user can choose to open with hover, but its not working 100%, needs to be cheked.
New components implemented: ix-divider & ix-dropdown-quick-actions
Example for quick-actions & submenu are done. (only missing Angular on the documentations, examples are done in Angular but the angular package is broken for me and it doesnt let me build the Angular package so i cannot run the examples on the docs).
Visual regression test is created for the quick-actions component.
Visual regression tetsts need to be checked and snapshots submitted.
Does this introduce a breaking change?
Testing
Other information