Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/theme): adjust theme colors #337

Merged
merged 15 commits into from
Feb 1, 2023
Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jan 31, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Replace with latest theme variables
  • Adjust visual regression tests
  • Improve documentation for existing variables
  • Check missing variables of existing

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jan 31, 2023
@danielleroux danielleroux added this to the 1.4.0 milestone Jan 31, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit a180cb8 into main Feb 1, 2023
@danielleroux danielleroux deleted the refactor/json-token-theme branch February 1, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants