-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/tabs): tab layout stretched and showNextArrow #345
Conversation
Tested it with the following snippet: <div
style={{
display: 'block',
position: 'relative',
width: '40rem',
backgroundColor: '#ff00002e',
}}
>
<ix-tabs layout="stretched">
<ix-tab-item>Test</ix-tab-item>
<ix-tab-item>Test</ix-tab-item>
<ix-tab-item>Test</ix-tab-item>
<ix-tab-item>Test</ix-tab-item>
</ix-tabs>
</div> |
Fixed. Tested with your code and it workes fine now. |
Please look into the visual-test results (https://github.com/siemens/ix/actions/runs/4115644754 download is on the bottom) seems there are problems regarding the |
@goncalosard checked out latest version. Test is not failing (😶 i will adapt this if the feature is working) but now iam not getting the correct overflow arrow. Maybe you should add an unit test to test the overflow behavior. <div style="margin-bottom: 2rem; width: 40rem; background-color: #ff00006a">
<ix-tabs>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
<ix-tab-item>Example</ix-tab-item>
</ix-tabs>
</div> Result: No overflow on right side: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #338
What is the new behavior?
Now layout="stretched" is working correctly.
Also fixed right arrow (showNextArrow), when overflow exists. Previously it was not showing when layout="auto" and overflow existed. Now it works correctly.
Does this introduce a breaking change?
Testing
Tested locally.
Other information