Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/toggle): toggle disable style #356

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #311

What is the new behavior?

Opacity changed to the requested 0.5

Border problem requested in the issue will automatically be fixed with the new Figma import, this problem is Figma related and not Toggle css code related.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested locally.

Other information

@goncalosard goncalosard added type: bug Something isn't working component: core labels Feb 6, 2023
@goncalosard goncalosard linked an issue Feb 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions the border which I do not see adressed here. Also we need to test the disabled state in visual regression testing.

@goncalosard
Copy link
Contributor Author

Border problem requested in the issue will automatically be fixed with the new Figma import, this problem is Figma related and not Toggle css code related.

Border problem is explained and resolved under "new behavior"

@danielleroux
Copy link
Collaborator

  • Added unit test
  • Improved visual regression test
  • merge latest main
  • update theme variables

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 5c4faf8 into main Feb 8, 2023
@danielleroux danielleroux deleted the fix/toggle-disable-style branch February 8, 2023 13:22
@danielleroux danielleroux added this to the 1.4.0 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle: styling of Disabled state
3 participants