Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/select): adjust dropdown placement #398

Merged
merged 6 commits into from
Feb 24, 2023
Merged

fix(core/select): adjust dropdown placement #398

merged 6 commits into from
Feb 24, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Adjust placement of dropdown during overflow case

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 23, 2023
@danielleroux danielleroux added this to the 1.4.0 milestone Feb 23, 2023
@danielleroux danielleroux linked an issue Feb 23, 2023 that may be closed by this pull request
Dropdown for the last row on aggrid is coming downwards #374
Closed
goncalosard
goncalosard approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@goncalosard goncalosard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danielleroux danielleroux merged commit 0a8e0a2 into main Feb 24, 2023
@danielleroux danielleroux deleted the fix-select-positioning branch February 24, 2023 07:55
@danielleroux danielleroux linked an issue Mar 3, 2023 that may be closed by this pull request
Component IxSelect displays options outside viewport #419
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalosard goncalosard goncalosard approved these changes

@nuke-ellington nuke-ellington Awaiting requested review from nuke-ellington

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Component IxSelect displays options outside viewport Dropdown for the last row on aggrid is coming downwards
2 participants
@danielleroux @goncalosard