Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update description breadcrumb #412

Merged
merged 12 commits into from
Mar 3, 2023

Conversation

linstedt
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

no ux desription :)

GitHub Issue Number: none

What is the new behavior?

Introduced new breadcrumb ux description, A few open points need to be clarified before merge

  • width and truncation of breadcrumb items:
  • interactivity of items: children can only be shown for last item? Mismatch with Figma component here
  • states: what states are available for interactive and not interactive items? Mismatch with Figma component here

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@linstedt linstedt added the Documentation Improvements or additions to documentation label Feb 28, 2023
@linstedt linstedt self-assigned this Feb 28, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux added this to the 1.4.0 milestone Mar 2, 2023
removed comments, add missing infos
@danielleroux danielleroux force-pushed the docs/update-description-breadcrumb branch from d7de48e to 6a3c467 Compare March 2, 2023 14:10
@danielleroux danielleroux merged commit 44540b4 into main Mar 3, 2023
@danielleroux danielleroux deleted the docs/update-description-breadcrumb branch March 3, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants