Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/workflow-step): icons overflow #426

Merged
merged 7 commits into from
Mar 15, 2023
Merged

fix(core/workflow-step): icons overflow #426

merged 7 commits into from
Mar 15, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #424

What is the new behavior?

  • Overflow now works correctly with the icons.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested locally.

Other information

@goncalosard goncalosard linked an issue Mar 3, 2023 that may be closed by this pull request
'ix-workflow-steps': The step icons overflow the container #424
Closed
@goncalosard goncalosard changed the title Fix/workflow steps overflow fix(core/workflow-step): icons overflow Mar 3, 2023
nuke-ellington
nuke-ellington requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add VRT to test overflow behavior

@goncalosard
Copy link
Contributor Author

Please add VRT to test overflow behavior

@nuke-ellington Done

@danielleroux danielleroux added this to the 1.5.0 milestone Mar 6, 2023
@danielleroux danielleroux added pull request affects patch version The pull request affects only patch version and removed component: core labels Mar 9, 2023
@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.1 Mar 9, 2023
@danielleroux danielleroux modified the milestones: 1.4.1, 1.5.0 Mar 14, 2023
nuke-ellington
nuke-ellington approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuke-ellington nuke-ellington merged commit 6c5f48a into main Mar 15, 2023
@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.2 Mar 20, 2023
danielleroux added a commit that referenced this pull request Mar 20, 2023
@goncalosard @danielleroux
fix(core/workflow-step):handle overflow gracefully (#426)
5e96f93 
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
@goncalosard goncalosard deleted the fix/workflow-steps-overflow branch April 18, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

'ix-workflow-steps': The step icons overflow the container
3 participants
@goncalosard @danielleroux @nuke-ellington