Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/chip): new custom event #441

Merged
merged 5 commits into from
Mar 13, 2023
Merged

fix(core/chip): new custom event #441

merged 5 commits into from
Mar 13, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #434

What is the new behavior?

  • Added new custom event (closeChip) to work with React
  • Added a stopImmediatePropagation so when you click the close button you don't trigger the main button event.
  • Added deprecated tag to old close event.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested locally.

Other information

@goncalosard goncalosard linked an issue Mar 10, 2023 that may be closed by this pull request
packages/core/src/components/chip/chip.tsx Outdated Show resolved Hide resolved
packages/core/src/components/chip/chip.tsx Show resolved Hide resolved
packages/core/src/components/chip/chip.tsx Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit f713fbd into main Mar 13, 2023
@danielleroux danielleroux deleted the fix/chip-event branch March 13, 2023 14:14
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 20, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close event on IxChip component
2 participants