Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): stop form trigger #446

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix(core/select): stop form trigger #446

merged 2 commits into from
Mar 14, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #442

What is the new behavior?

  • Added button type to dropdown-item to stop form using button as submit type.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added type: bug Something isn't working component: core labels Mar 14, 2023
@goncalosard goncalosard linked an issue Mar 14, 2023 that may be closed by this pull request
@danielleroux danielleroux added pull request affects patch version The pull request affects only patch version and removed type: bug Something isn't working component: core labels Mar 14, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 14, 2023
@danielleroux danielleroux merged commit 03b04a6 into main Mar 14, 2023
@danielleroux danielleroux deleted the fix/select-form branch March 14, 2023 13:16
@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.2 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-select should not submit form
2 participants