Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/group): header and item hover/active style #453

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #445

What is the new behavior?

  • Fixed hover/active on group header to not change when selected.
  • Fixed hover/active on group-item to not change when selected.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard linked an issue Mar 16, 2023 that may be closed by this pull request
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 17, 2023
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 17, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRT tests would be nice :)

@goncalosard
Copy link
Contributor Author

VRT tests would be nice :)

Added vrt

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also do the same VRTing for the group item please?

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 64cd604 into main Mar 24, 2023
@goncalosard goncalosard deleted the fix/group-header branch March 28, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-group header selected :hover :active not correct
3 participants