Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expanding-search): example height #454

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Example zone height not high enough, making a scroll bar appear.

image

What is the new behavior?

  • Increased height from 4rem to 5rem.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux changed the title fix(docs/expanding-search): example zone height docs(expanding-search): example height Mar 17, 2023
@danielleroux danielleroux added the Documentation Improvements or additions to documentation label Mar 17, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 17, 2023
@danielleroux danielleroux merged commit b38c936 into main Mar 17, 2023
@danielleroux danielleroux deleted the fix/expanding-search-docs branch March 17, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants