fix(core/blind): improve keyboard accessibility #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleroux
added
the
pull request affects patch version
danielleroux
changed the title
danielleroux
requested changes
Mar 28, 2023
danielleroux
approved these changes
Mar 31, 2023
danielleroux
requested changes
Mar 31, 2023
danielleroux
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn test) were run locally and passedyarn visual-regression) were run locally and passednpm lint) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Prior to this change, blind components were not keyboard operable, which was an accessibility issue. This has now been fixed, while also providing the required visibility of the associated focus frame. To make the individual elements of blind component instances referenceable within the required WAI-ARIA attribution, they have been assigned unique IDs, which has been realized via an additional module-scoped sequential number (namely 'sequentialInstanceId').
Does this introduce a breaking change?
Testing
Other information