Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/select): clear button #465

Merged
merged 5 commits into from
Mar 30, 2023
Merged

fix(core/select): clear button #465

merged 5 commits into from
Mar 30, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #456

What is the new behavior?

  • Clear button now works for Single select and Multiselect
  • Adjusted the clear button size as designed

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard linked an issue Mar 23, 2023 that may be closed by this pull request
Clear Button not displayed in single select #456
Closed
nuke-ellington
nuke-ellington reviewed Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it not show up in VRT?

@goncalosard
Copy link
Contributor Author

Why does it not show up in VRT?

None of the existing examples had the property to use the clear button.
Added a vrt to test the clear button.

nuke-ellington
nuke-ellington requested changes Mar 24, 2023
View reviewed changes
packages/core/src/components/select/select.tsx Outdated Show resolved Hide resolved
packages/core/src/tests/select/select.e2e.ts Outdated Show resolved Hide resolved
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 24, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 24, 2023
nuke-ellington
nuke-ellington reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nuke-ellington
nuke-ellington approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit f8e7d93 into main Mar 30, 2023
@danielleroux danielleroux deleted the fix/clear-button branch March 30, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

@danielleroux danielleroux Awaiting requested review from danielleroux

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Clear Button not displayed in single select
3 participants
@goncalosard @nuke-ellington @danielleroux