-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/group): group selected style and actions & header correction #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-ellington
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Click on header shoud deselect group items
- Focus border was lost (@silviowolf will update to latest design spec)
danielleroux
added
the
pull request affects patch version
The pull request affects only patch version
label
Mar 30, 2023
…ns/ix into fix/group-header-alignment
@danielleroux @nuke-ellington
|
danielleroux
requested changes
Mar 31, 2023
danielleroux
requested changes
Mar 31, 2023
danielleroux
requested changes
Mar 31, 2023
danielleroux
approved these changes
Apr 6, 2023
nuke-ellington
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Old style:
Selected style is not correct according to Figma.
When item is selected, then dropdown is closed and reopened, item no longer shows clicked.
When item is selected and the dropdown is closed, it puts header selected.
Also GitHub Issue Number: #416
What is the new behavior?
New style:
Does this introduce a breaking change?
Testing
Other information