Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/select): hide header text #471

Merged
merged 5 commits into from
Apr 4, 2023
Merged

feat(core/select): hide header text #471

merged 5 commits into from
Apr 4, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #468

What is the new behavior?

  • Now with a prop the user can activate it to not display the list header

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added this to the 1.6.0 milestone Mar 29, 2023
@goncalosard goncalosard linked an issue Mar 29, 2023 that may be closed by this pull request
Cannot stop IxSelect from displaying ListHeader #468
Closed
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Mar 30, 2023
@danielleroux danielleroux changed the title fix(core/select): hide listHeader feat(core/select): hide header text Mar 30, 2023
@goncalosard goncalosard modified the milestones: 1.6.0, 1.5.0 Mar 30, 2023
nuke-ellington
nuke-ellington approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

danielleroux
danielleroux approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goncalosard lgtm, but there are some merge conflicts which has to be resolved.

@goncalosard
Copy link
Contributor Author

@goncalosard lgtm, but there are some merge conflicts which has to be resolved.

@danielleroux It's ready to be merged

@danielleroux danielleroux merged commit 795d326 into main Apr 4, 2023
@danielleroux danielleroux deleted the fix/select-listheader branch April 4, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Cannot stop IxSelect from displaying ListHeader
3 participants
@goncalosard @danielleroux @nuke-ellington