Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/menu-avatar): optional logout button, conditional dropdown #851

Merged
merged 11 commits into from
Nov 14, 2023
Merged

feat(core/menu-avatar): optional logout button, conditional dropdown #851

merged 11 commits into from
Nov 14, 2023

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Oct 17, 2023 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • logout is always shown inside the avatar menu
  • therefore the dropdown is also always shown
  • no possible way to deactivate the logout

GitHub Issue Number: N/A

What is the new behavior?

  • logout button can be deactivated
  • dropdown is not shown if nothing is passed and the dropdown button is deactivated

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader linked an issue Oct 17, 2023 that may be closed by this pull request
change the logout button to optional in ix-menu-avatar #843
Closed
@matthiashader matthiashader marked this pull request as draft October 17, 2023 08:16
@matthiashader matthiashader marked this pull request as ready for review October 18, 2023 08:18
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Oct 20, 2023
@nuke-ellington nuke-ellington removed the request for review from danielleroux November 13, 2023 14:12
@nuke-ellington nuke-ellington merged commit 3a51843 into main Nov 14, 2023
7 checks passed
nuke-ellington pushed a commit that referenced this pull request Nov 20, 2023
@matthiashader @danielleroux @nuke-ellington
feat(core/menu-avatar): optional logout button, conditional dropdown (#…
5f49397 
…851)

Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
@danielleroux danielleroux deleted the feat/menu-avatar branch January 23, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees

@matthiashader matthiashader

Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

change the logout button to optional in ix-menu-avatar
3 participants
@matthiashader @danielleroux @nuke-ellington