fix(core/styles): change pseudo selector to focus-visible #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleroux
changed the title
danielleroux
added
component: core
pull request affects patch version
|
@goncalosard at first glance it look like you got the functionality implemented correctly. Can you please take care of the formatting. We should keep the spaces (e.g. around + selectors) and we dont need all those empty line imo. Also please consider the focus-visible mixin from _hover.scss. |
|
@nuke-ellington the formatting + empty lines etc, were added by lint. Me saving the file added all does changes cause of lint. |
nuke-ellington
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the focus handles to focus-visible.
Please let me know if this was the intended goal.