Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/expanding-serach): expanding search sizing #96

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

goncalosard
Copy link
Contributor

Summary

Fixed the problem where in collapsed state the component had the size of expanded state.

Now the size when collapsed is the size of the icon only.

With this new change, it meant there was a problem where if it all the way to the right(ex: flex-end), the component would overflow outside of the div it was in. Also fixed this problem.

@danielleroux danielleroux changed the title Fix/expanding search fix(core/expanding-serach): expanding search sizing Oct 28, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changed the flex to inline-flex.
  • Added a visual regression-testcase

lgtm.

@danielleroux danielleroux self-assigned this Oct 28, 2022
@danielleroux danielleroux added component: core pull request affects patch version The pull request affects only patch version labels Oct 28, 2022
@danielleroux danielleroux added this to the 1.1.0 milestone Oct 28, 2022
@danielleroux danielleroux merged commit 42db707 into main Oct 28, 2022
@danielleroux danielleroux deleted the fix/expanding-search branch October 28, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ix-expanding-search uses in collapsed state min-width of expanded
2 participants