Skip to content

Commit

Permalink
tools: jailhouse: Do not dump console on enabling errors
Browse files Browse the repository at this point in the history
We cannot reliably tell apart errors that happen before we call into the
hypervisor binary from those that happen after that. The latters may
have left some relevant messages in the console buffer, but the former
can make us dump confusing messages from a previous Jailhouse run.

Better let the user decide if the console content should be shown via an
explicit invocation of "jailhouse console".

Reported-and-suggested-by: Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
  • Loading branch information
jan-kiszka committed Apr 28, 2017
1 parent 3dde793 commit a9bf0d3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tools/jailhouse.c
Expand Up @@ -234,10 +234,8 @@ static int enable(int argc, char *argv[])
fd = open_dev();

err = ioctl(fd, JAILHOUSE_ENABLE, config);
if (err) {
if (err)
perror("JAILHOUSE_ENABLE");
dump_console(fd, true);
}

close(fd);
free(config);
Expand Down

0 comments on commit a9bf0d3

Please sign in to comment.