Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): Enable the usage of modifier keys #408

Merged

Conversation

TobiasSchaffner
Copy link
Contributor

Expose a press function in the keyboard controller that handles the press of a single key with modifier keys. Use this function from the web UI to allow to hit key combinations like ctrl-c.

Can please somebody test this with qemu? I do not have a running qemu setup atm.

@chombourger
Copy link
Collaborator

was traveling this week. I will now take a look, thanks!

@chombourger
Copy link
Collaborator

your changes passed the emacs test!

image

let's get the flake8 errors and we will be good to merge this

thank you @TobiasSchaffner !

Expose a press function in the keyboard controller that handles the
press of a single key with modifier keys.

The write function uses this function multiple times to send a sequence
of characters.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
Send the modifier keys (ctrl, shift, alt, meta) together with the
send key. This allows for example allows to hit crtl-c.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
@TobiasSchaffner TobiasSchaffner force-pushed the tobsch/keyboard-send-modifier-keys branch from 7531f84 to af970b9 Compare March 9, 2024 15:35
@TobiasSchaffner
Copy link
Contributor Author

your changes passed the emacs test!

image

let's get the flake8 errors and we will be good to merge this

thank you @TobiasSchaffner !

Great thanks @chombourger. I changed the maximum line length to 120 chars with an additional commit. Do you prefer to stick to the 80 characters?

@chombourger chombourger removed the check label Mar 10, 2024
@chombourger
Copy link
Collaborator

your changes passed the emacs test!
image
let's get the flake8 errors and we will be good to merge this
thank you @TobiasSchaffner !

Great thanks @chombourger. I changed the maximum line length to 120 chars with an additional commit. Do you prefer to stick to the 80 characters?

I’m fine with this, I always found this 80 char max rule silly

@chombourger chombourger merged commit 530640a into siemens:master Mar 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants